• Daniel Latypov's avatar
    kunit: tool: misc cleanups · 0453f984
    Daniel Latypov authored
    This primarily comes from running pylint over kunit tool code and
    ignoring some warnings we don't care about.
    If we ever got a fully clean setup, we could add this to run_checks.py,
    but we're not there yet.
    
    Fix things like
    * Drop unused imports
    * check `is None`, not `== None` (see PEP 8)
    * remove redundant parens around returns
    * remove redundant `else` / convert `elif` to `if` where appropriate
    * rename make_arch_qemuconfig() param to base_kunitconfig (this is the
      name used in the subclass, and it's a better one)
    * kunit_tool_test: check the exit code for SystemExit (could be 0)
    Signed-off-by: default avatarDaniel Latypov <dlatypov@google.com>
    Reviewed-by: default avatarDavid Gow <davidgow@google.com>
    Reviewed-by: default avatarBrendan Higgins <brendanhiggins@google.com>
    Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
    0453f984
run_checks.py 2.29 KB