• Eric W. Biederman's avatar
    veth: Fix the byte counters · 675071a2
    Eric W. Biederman authored
    Commit 44540960 "veth: move loopback logic to common location" introduced
    a bug in the packet counters.  I don't understand why that happened as it
    is not explained in the comments and the mut check in dev_forward_skb
    retains the assumption that skb->len is the total length of the packet.
    
    I just measured this emperically by setting up a veth pair between two
    noop network namespaces setting and attempting a telnet connection between
    the two.  I saw three packets in each direction and the byte counters were
    exactly 14*3 = 42 bytes high in each direction.  I got the actual
    packet lengths with tcpdump.
    
    So remove the extra ETH_HLEN from the veth byte count totals.
    Signed-off-by: default avatarEric W. Biederman <ebiederm@aristanetworks.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    675071a2
veth.c 9.8 KB