• Rik van Riel's avatar
    cpuidle,menu: smooth out measured_us calculation · efddfd90
    Rik van Riel authored
    The cpuidle state tables contain the maximum exit latency for each
    cpuidle state. On x86, that is the exit latency for when the entire
    package goes into that same idle state.
    
    However, a lot of the time we only go into the core idle state,
    not the package idle state. This means we see a much smaller exit
    latency.
    
    We have no way to detect whether we went into the core or package
    idle state while idle, and that is ok.
    
    However, the current menu_update logic does have the potential to
    trip up the repeating pattern detection in get_typical_interval.
    If the system is experiencing an exit latency near the idle state's
    exit latency, some of the samples will have exit_us subtracted,
    while others will not. This turns a repeating pattern into mush,
    potentially breaking get_typical_interval.
    
    Furthermore, for smaller sleep intervals, we know the chance that
    all the cores in the package went to the same idle state are fairly
    small. Dividing the measured_us by two, instead of subtracting the
    full exit latency when hitting a small measured_us, will reduce the
    error.
    Signed-off-by: default avatarRik van Riel <riel@redhat.com>
    Acked-by: default avatarArjan van de Ven <arjan@linux.intel.com>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    efddfd90
menu.c 14.7 KB