• Jiri Slaby's avatar
    perf symbols: Resolve symbols against debug file first · 6833e0b8
    Jiri Slaby authored
    With LTO, there are symbols like these:
    
    /usr/lib/debug/usr/lib64/libantlr4-runtime.so.4.8-4.8-1.4.x86_64.debug
     10305: 0000000000955fa4     0 NOTYPE  LOCAL  DEFAULT   29 Predicate.cpp.2bc410e7
    
    This comes from a runtime/debug split done by the standard way:
    
      objcopy --only-keep-debug $runtime $debug
      objcopy --add-gnu-debuglink=$debugfn -R .comment -R .GCC.command.line --strip-all $runtime
    
    perf currently cannot resolve such symbols (relicts of LTO), as section
    29 exists only in the debug file (29 is .debug_info). And perf resolves
    symbols only against runtime file. This results in all symbols from such
    a library being unresolved:
    
         0.38%  main2    libantlr4-runtime.so.4.8  [.] 0x00000000000671e0
    
    So try resolving against the debug file first. And only if it fails (the
    section has NOBITS set), try runtime file. We can do this, as "objcopy
    --only-keep-debug" per documentation preserves all sections, but clears
    data of some of them (the runtime ones) and marks them as NOBITS.
    
    The correct result is now:
         0.38%  main2    libantlr4-runtime.so.4.8  [.] antlr4::IntStream::~IntStream
    
    Note that these LTO symbols are properly skipped anyway as they belong
    neither to *text* nor to *data* (is_label && !elf_sec__filter(&shdr,
    secstrs) is true).
    Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
    Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/20210217122125.26416-1-jslaby@suse.czSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    6833e0b8
symbol-elf.c 54.6 KB