• Harvey Harrison's avatar
    kgdb: fix signedness mixmatches, add statics, add declaration to header · 688b744d
    Harvey Harrison authored
    Noticed by sparse:
    arch/x86/kernel/kgdb.c:556:15: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static?
    kernel/kgdb.c:149:8: warning: symbol 'kgdb_do_roundup' was not declared. Should it be static?
    kernel/kgdb.c:193:22: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static?
    kernel/kgdb.c:712:5: warning: symbol 'remove_all_break' was not declared. Should it be static?
    
    Related to kgdb_hex2long:
    arch/x86/kernel/kgdb.c:371:28: warning: incorrect type in argument 2 (different signedness)
    arch/x86/kernel/kgdb.c:371:28:    expected long *long_val
    arch/x86/kernel/kgdb.c:371:28:    got unsigned long *<noident>
    kernel/kgdb.c:469:27: warning: incorrect type in argument 2 (different signedness)
    kernel/kgdb.c:469:27:    expected long *long_val
    kernel/kgdb.c:469:27:    got unsigned long *<noident>
    kernel/kgdb.c:470:27: warning: incorrect type in argument 2 (different signedness)
    kernel/kgdb.c:470:27:    expected long *long_val
    kernel/kgdb.c:470:27:    got unsigned long *<noident>
    kernel/kgdb.c:894:27: warning: incorrect type in argument 2 (different signedness)
    kernel/kgdb.c:894:27:    expected long *long_val
    kernel/kgdb.c:894:27:    got unsigned long *<noident>
    kernel/kgdb.c:895:27: warning: incorrect type in argument 2 (different signedness)
    kernel/kgdb.c:895:27:    expected long *long_val
    kernel/kgdb.c:895:27:    got unsigned long *<noident>
    kernel/kgdb.c:1127:28: warning: incorrect type in argument 2 (different signedness)
    kernel/kgdb.c:1127:28:    expected long *long_val
    kernel/kgdb.c:1127:28:    got unsigned long *<noident>
    kernel/kgdb.c:1132:25: warning: incorrect type in argument 2 (different signedness)
    kernel/kgdb.c:1132:25:    expected long *long_val
    kernel/kgdb.c:1132:25:    got unsigned long *<noident>
    Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
    Signed-off-by: default avatarJason Wessel <jason.wessel@windriver.com>
    688b744d
kgdb.c 37.7 KB