• Jesper Dangaard Brouer's avatar
    xdp: remove memory poison on free for struct xdp_mem_allocator · c491eae8
    Jesper Dangaard Brouer authored
    When looking at the details I realised that the memory poison in
    __xdp_mem_allocator_rcu_free doesn't make sense. This is because the
    SLUB allocator uses the first 16 bytes (on 64 bit), for its freelist,
    which overlap with members in struct xdp_mem_allocator, that were
    updated.  Thus, SLUB already does the "poisoning" for us.
    
    I still believe that poisoning memory make sense in other cases.
    Kernel have gained different use-after-free detection mechanism, but
    enabling those is associated with a huge overhead. Experience is that
    debugging facilities can change the timing so much, that that a race
    condition will not be provoked when enabled. Thus, I'm still in favour
    of poisoning memory where it makes sense.
    Signed-off-by: default avatarJesper Dangaard Brouer <brouer@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c491eae8
xdp.c 11.7 KB