• Al Viro's avatar
    nfs_remount(): don't leak, don't ignore LSM options quietly · 6a0440e5
    Al Viro authored
    * if mount(2) passes something like "context=foo" with MS_REMOUNT
    in flags (/sbin/mount.nfs will _not_ do that - you need to issue
    the syscall manually), you'll get leaked copies for LSM options.
    The reason is that instead of nfs_{alloc,free}_parsed_mount_data()
    nfs_remount() uses kzalloc/kfree, which lacks the needed cleanup.
    
    * selinux options are not changed on remount (as for any other
    fs), but in case of NFS the failure is quiet - they are not compared
    to what we used to have, with complaint in case of attempted changes.
    Trivially fixed by converting to use of security_sb_remount().
    Reviewed-by: default avatarDavid Howells <dhowells@redhat.com>
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    6a0440e5
super.c 75.7 KB