• Jonathan Cameron's avatar
    iio:humidity:hdc100x Fix alignment and data leak issues · ea5e7a7b
    Jonathan Cameron authored
    One of a class of bugs pointed out by Lars in a recent review.
    iio_push_to_buffers_with_timestamp assumes the buffer used is aligned
    to the size of the timestamp (8 bytes).  This is not guaranteed in
    this driver which uses an array of smaller elements on the stack.
    As Lars also noted this anti pattern can involve a leak of data to
    userspace and that indeed can happen here.  We close both issues by
    moving to a suitable structure in the iio_priv() data.
    This data is allocated with kzalloc so no data can leak apart
    from previous readings.
    
    Fixes: 16bf793f ("iio: humidity: hdc100x: add triggered buffer support for HDC100X")
    Reported-by: default avatarLars-Peter Clausen <lars@metafoo.de>
    Acked-by: default avatarMatt Ranostay <matt.ranostay@konsulko.com>
    Cc: Alison Schofield <amsfield22@gmail.com>
    Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
    Cc: <Stable@vger.kernel.org>
    ea5e7a7b
hdc100x.c 10.5 KB