• Sai Prakash Ranjan's avatar
    pstore/ram: Fix console ramoops to show the previous boot logs · 6a4c9ab1
    Sai Prakash Ranjan authored
    commit b05c9506 ("pstore/ram: Simplify ramoops_get_next_prz()
    arguments") changed update assignment in getting next persistent ram zone
    by adding a check for record type. But the check always returns true since
    the record type is assigned 0. And this breaks console ramoops by showing
    current console log instead of previous log on warm reset and hard reset
    (actually hard reset should not be showing any logs).
    
    Fix this by having persistent ram zone type check instead of record type
    check. Tested this on SDM845 MTP and dragonboard 410c.
    
    Reproducing this issue is simple as below:
    
    1. Trigger hard reset and mount pstore. Will see console-ramoops
       record in the mounted location which is the current log.
    
    2. Trigger warm reset and mount pstore. Will see the current
       console-ramoops record instead of previous record.
    
    Fixes: b05c9506 ("pstore/ram: Simplify ramoops_get_next_prz() arguments")
    Signed-off-by: default avatarSai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
    Acked-by: default avatarJoel Fernandes (Google) <joel@joelfernandes.org>
    [kees: dropped local variable usage]
    Signed-off-by: default avatarKees Cook <keescook@chromium.org>
    6a4c9ab1
ram.c 24.4 KB