• Gustavo A. R. Silva's avatar
    media: tuners: remove unnecessary static in simple_dvb_configure() · 6ad33dec
    Gustavo A. R. Silva authored
    Remove unnecessary static on local variable t_params.
    Such variable is initialized before being used,
    on every execution path throughout the function.
    The static has no benefit and, removing it reduces
    the code size.
    
    This issue was detected using Coccinelle and the following semantic patch:
    
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x@p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x@p;
     ... when != x
         when strict
    ?x = e;
    
    In the following log you can see the difference in the code size. Also,
    there is a significant difference in the bss segment. This log is the
    output of the size command, before and after the code change:
    
    before:
       text    data     bss     dec     hex filename
      23314    3640     832   27786    6c8a drivers/media/tuners/tuner-simple.o
    
    after:
       text    data     bss     dec     hex filename
      23257    3552     768   27577    6bb9 drivers/media/tuners/tuner-simple.o
    Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
    Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    6ad33dec
tuner-simple.c 28.6 KB