• Marco Elver's avatar
    perf: Fix data race between pin_count increment/decrement · 6c605f83
    Marco Elver authored
    KCSAN reports a data race between increment and decrement of pin_count:
    
      write to 0xffff888237c2d4e0 of 4 bytes by task 15740 on cpu 1:
       find_get_context		kernel/events/core.c:4617
       __do_sys_perf_event_open	kernel/events/core.c:12097 [inline]
       __se_sys_perf_event_open	kernel/events/core.c:11933
       ...
      read to 0xffff888237c2d4e0 of 4 bytes by task 15743 on cpu 0:
       perf_unpin_context		kernel/events/core.c:1525 [inline]
       __do_sys_perf_event_open	kernel/events/core.c:12328 [inline]
       __se_sys_perf_event_open	kernel/events/core.c:11933
       ...
    
    Because neither read-modify-write here is atomic, this can lead to one
    of the operations being lost, resulting in an inconsistent pin_count.
    Fix it by adding the missing locking in the CPU-event case.
    
    Fixes: fe4b04fa ("perf: Cure task_oncpu_function_call() races")
    Reported-by: syzbot+142c9018f5962db69c7e@syzkaller.appspotmail.com
    Signed-off-by: default avatarMarco Elver <elver@google.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Link: https://lkml.kernel.org/r/20210527104711.2671610-1-elver@google.com
    6c605f83
core.c 319 KB