• Andreas Gruenbacher's avatar
    xattr: Stop calling {get,set,remove}xattr inode operations · 6c6ef9f2
    Andreas Gruenbacher authored
    All filesystems that support xattrs by now do so via xattr handlers.
    They all define sb->s_xattr, and their getxattr, setxattr, and
    removexattr inode operations use the generic inode operations.  On
    filesystems that don't support xattrs, the xattr inode operations are
    all NULL, and sb->s_xattr is also NULL.
    
    This means that we can remove the getxattr, setxattr, and removexattr
    inode operations and directly call the generic handlers, or better,
    inline expand those handlers into fs/xattr.c.
    
    Filesystems that do not support xattrs on some inodes should clear the
    IOP_XATTR i_opflags flag in those inodes.  (Right now, some filesystems
    have checks to disable xattrs on some inodes in the ->list, ->get, and
    ->set xattr handler operations instead.)  The IOP_XATTR flag is
    automatically cleared in inodes of filesystems that don't have xattr
    support.
    
    In orangefs, symlinks do have a setxattr iop but no getxattr iop.  Add a
    check for symlinks to orangefs_inode_getxattr to preserve the current,
    weird behavior; that check may not be necessary though.
    Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    6c6ef9f2
Locking 23.9 KB