• Darrick J. Wong's avatar
    xfs: abort directory parent scrub scans if we encounter a zapped directory · 6c728952
    Darrick J. Wong authored
    In a previous patch, we added some code to perform sufficient repairs
    to an ondisk inode record such that the inode cache would be willing to
    load the inode.  If the broken inode was a shortform directory, it will
    reset the directory to something plausible, which is to say an empty
    subdirectory of the root.  The telltale signs that something is
    seriously wrong is the broken link count.
    
    Such directories look clean, but they shouldn't participate in a
    filesystem scan to find or confirm a directory parent pointer.  Create a
    predicate that identifies such directories and abort the scrub.
    
    Found by fuzzing xfs/1554 with multithreaded xfs_scrub enabled and
    u3.bmx[0].startblock = zeroes.
    Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    6c728952
parent.c 5.73 KB