• Alan Stern's avatar
    PM: Fix async resume following suspend failure · 6d0e0e84
    Alan Stern authored
    The PM core doesn't handle suspend failures correctly when it comes to
    asynchronously suspended devices.  These devices are moved onto the
    dpm_suspended_list as soon as the corresponding async thread is
    started up, and they remain on the list even if they fail to suspend
    or the sleep transition is cancelled before they get suspended.  As a
    result, when the PM core unwinds the transition, it tries to resume
    the devices even though they were never suspended.
    
    This patch (as1474) fixes the problem by adding a new "is_suspended"
    flag to dev_pm_info.  Devices are resumed only if the flag is set.
    
    [rjw:
     * Moved the dev->power.is_suspended check into device_resume(),
       because we need to complete dev->power.completion and clear
       dev->power.is_prepared too for devices whose
       dev->power.is_suspended flags are unset.
     * Fixed __device_suspend() to avoid setting dev->power.is_suspended
       if async_error is different from zero.]
    Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
    Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
    Cc: stable@kernel.org
    6d0e0e84
main.c 27.1 KB