• Takashi Iwai's avatar
    ALSA: usb-audio: Fix regression by disconnection-race-fix patch · 6d3e269c
    Takashi Iwai authored
    [NOTE: the regression below is found only in 3.2-3.4 stable trees, so
           there is no upstream commit corresponding to this patch]
    
    The recent fix for the race at disconnection of usb-audio devices
    (upstream commit 978520b7) triggers Oops when a device is unplugged
    while playing on 3.2 and 3.4 kernels.  The culprit is that the
    shutdown flag check was wrongly added around the urb deactivation code
    snippet.  The urb deactivation code has to be performed even after the
    device disconnected.  Otherwise it remains undead and pokes the wild
    access in the end.
    
    The regression fix is simply reverting the shutdown flag check in that
    code.
    Reported-and-tested-by: default avatarChris J Arges <christopherarges@gmail.com>
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    6d3e269c
endpoint.c 26 KB