• Ryan Roberts's avatar
    selftests/mm: fix thuge-gen test bugs · 6e16f513
    Ryan Roberts authored
    thuge-gen was previously only munmapping part of the mmapped buffer, which
    caused us to run out of 1G huge pages for a later part of the test.  Fix
    this by munmapping the whole buffer.  Based on the code, it looks like a
    typo rather than an intention to keep some of the buffer mapped.
    
    thuge-gen was also calling mmap with SHM_HUGETLB flag (bit 11 set), which
    is actually MAP_DENYWRITE in mmap context.  The man page says this flag is
    ignored in modern kernels.  I'm pretty sure from the context that the
    author intended to pass the MAP_HUGETLB flag so I've fixed that up too.
    
    Link: https://lkml.kernel.org/r/20230724082522.1202616-5-ryan.roberts@arm.comSigned-off-by: default avatarRyan Roberts <ryan.roberts@arm.com>
    Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
    Cc: Florent Revest <revest@chromium.org>
    Cc: Jérôme Glisse <jglisse@redhat.com>
    Cc: John Hubbard <jhubbard@nvidia.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Peter Xu <peterx@redhat.com>
    Cc: Shuah Khan <shuah@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    6e16f513
thuge-gen.c 5.58 KB