• Giuseppe CAVALLARO's avatar
    stmmac: dwmac-sti: review the glue-logic for STi4xx and STiD127 SoCs · 53b26b9b
    Giuseppe CAVALLARO authored
    This patch is to review the whole glue logic adopted on STi SoCs that
    was bugged.
    
    In the old glue-logic there was a lot of confusion when setup the
    retiming especially for STiD127 where, for example, the bits 6 and 7
    (in the GMAC  control register) have a different meaning of what is
    used for STiH4xx SoCs. So we cannot adopt the same glue for all these
    SoCs.
    Moreover, GiGa on STiD127 didn't work and, for all the SoCs, the RGMII
    couldn't run when the speed was 10Mbps (because the clock was not properly
    managed).
    Note that the phy clock needs to be provided by the platform as well as
    documented in the related binding file (updated as consequence).
    
    The old code supported too many configurations never adopted and validated.
    This made the code very complex to maintain and debug in case of issues.
    
    The patch simplifies all the configurations as commented in the tables
    inside the file and obviously it has been tested on all the boards
    based on the SoCs mentioned.
    
    With this patch, the dwmac-sti is also ready to support new configurations that
    will be available on next SoC generations.
    Signed-off-by: default avatarGiuseppe Cavallaro <peppe.cavallaro@st.com>
    Cc: Srinivas Kandagatla <srinivas.kandagatla@st.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    53b26b9b
sti-dwmac.txt 2.38 KB