• Thomas Gleixner's avatar
    ALSA: pcsp: Make hrtimer forwarding more robust · f2ff7147
    Thomas Gleixner authored
    The hrtimer callback pcsp_do_timer() prepares rearming of the timer with
    hrtimer_forward(). hrtimer_forward() is intended to provide a mechanism to
    forward the expiry time of the hrtimer by a multiple of the period argument
    so that the expiry time greater than the time provided in the 'now'
    argument.
    
    pcsp_do_timer() invokes hrtimer_forward() with the current timer expiry
    time as 'now' argument. That's providing a periodic timer expiry, but is
    not really robust when the timer callback is delayed so that the resulting
    new expiry time is already in the past which causes the callback to be
    invoked immediately again. If the timer is delayed then the back to back
    invocation is not really making it better than skipping the missed
    periods. Sound is distorted in any case.
    
    Use hrtimer_forward_now() which ensures that the next expiry is in the
    future. This prevents hogging the CPU in the timer expiry code and allows
    later on to remove hrtimer_forward() from the public interfaces.
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: alsa-devel@alsa-project.org
    Cc: Takashi Iwai <tiwai@suse.com>
    Cc: Jaroslav Kysela <perex@perex.cz>
    Link: https://lore.kernel.org/r/20210923153339.623208460@linutronix.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    f2ff7147
pcsp_lib.c 8.84 KB