• Jan Kara's avatar
    udf: Fix race between write(2) and close(2) · 6fb1ca92
    Jan Kara authored
    Currently write(2) updating i_size and close(2) of the file can race in
    such a way that udf_truncate_tail_extent() called from
    udf_file_release() sees old i_size but already new extents added by the
    running write call. This results in complaints like:
      UDF-fs: warning (device vdb2): udf_truncate_tail_extent: Too long extent
        after EOF in inode 877: i_size: 0 lbcount: 1073739776 extent 0+1073739776
      UDF-fs: error (device vdb2): udf_truncate_tail_extent: Extent after EOF
        in inode 877
    
    Fix the problem by grabbing i_mutex in udf_file_release() to be sure
    i_size is consistent with current state of extent list. Also avoid
    truncating tail extent unnecessarily when the file is still open for
    writing.
    Signed-off-by: default avatarJan Kara <jack@suse.cz>
    6fb1ca92
file.c 6.7 KB