• Dave Marchevsky's avatar
    bpf: Migrate cgroup_bpf to internal cgroup_bpf_attach_type enum · 6fc88c35
    Dave Marchevsky authored
    Add an enum (cgroup_bpf_attach_type) containing only valid cgroup_bpf
    attach types and a function to map bpf_attach_type values to the new
    enum. Inspired by netns_bpf_attach_type.
    
    Then, migrate cgroup_bpf to use cgroup_bpf_attach_type wherever
    possible.  Functionality is unchanged as attach_type_to_prog_type
    switches in bpf/syscall.c were preventing non-cgroup programs from
    making use of the invalid cgroup_bpf array slots.
    
    As a result struct cgroup_bpf uses 504 fewer bytes relative to when its
    arrays were sized using MAX_BPF_ATTACH_TYPE.
    
    bpf_cgroup_storage is notably not migrated as struct
    bpf_cgroup_storage_key is part of uapi and contains a bpf_attach_type
    member which is not meant to be opaque. Similarly, bpf_cgroup_link
    continues to report its bpf_attach_type member to userspace via fdinfo
    and bpf_link_info.
    
    To ease disambiguation, bpf_attach_type variables are renamed from
    'type' to 'atype' when changed to cgroup_bpf_attach_type.
    Signed-off-by: default avatarDave Marchevsky <davemarchevsky@fb.com>
    Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
    Link: https://lore.kernel.org/bpf/20210819092420.1984861-2-davemarchevsky@fb.com
    6fc88c35
cgroup.c 51.8 KB