• Matt Fleming's avatar
    x86/mm/pat: Prevent hang during boot when mapping pages · e535ec08
    Matt Fleming authored
    There's a mixture of signed 32-bit and unsigned 32-bit and 64-bit data
    types used for keeping track of how many pages have been mapped.
    
    This leads to hangs during boot when mapping large numbers of pages
    (multiple terabytes, as reported by Waiman) because those values are
    interpreted as being negative.
    
    commit 74256377 ("x86/mm/pat: Avoid truncation when converting
    cpa->numpages to address") fixed one of those bugs, but there is
    another lurking in __change_page_attr_set_clr().
    
    Additionally, the return value type for the populate_*() functions can
    return negative values when a large number of pages have been mapped,
    triggering the error paths even though no error occurred.
    
    Consistently use 64-bit types on 64-bit platforms when counting pages.
    Even in the signed case this gives us room for regions 8PiB
    (pebibytes) in size whilst still allowing the usual negative value
    error checking idiom.
    Reported-by: default avatarWaiman Long <waiman.long@hpe.com>
    Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    CC: Theodore Ts'o <tytso@mit.edu>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Scott J Norton <scott.norton@hpe.com>
    Cc: Douglas Hatch <doug.hatch@hpe.com>
    Signed-off-by: default avatarMatt Fleming <matt@codeblueprint.co.uk>
    e535ec08
pageattr.c 47.6 KB