• James Hogan's avatar
    [media] media: rc: only turn on LED if keypress generated · 70a2f912
    James Hogan authored
    Since v3.12, specifically 153a60bb ([media] rc: add feedback led
    trigger for rc keypresses), an LED trigger is activated on IR keydown
    whether or not a keypress is generated (i.e. even if there's no matching
    keycode). However the repeat and keyup logic isn't used unless there is
    a keypress, which results in non-keypress keydown events turning on the
    LED and not turning it off again.
    
    On the assumption that the intent was for the LED only to light up on
    valid key presses (you probably don't want it lighting up for the wrong
    remote control for example), move the led_trigger_event() call inside
    the keycode check.
    Signed-off-by: default avatarJames Hogan <james.hogan@imgtec.com>
    Acked-by: default avatarSean Young <sean@mess.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
    70a2f912
rc-main.c 31.8 KB