• Sameer Pujar's avatar
    ASoC: rt5640: Fix sleep in atomic context · 70a6404f
    Sameer Pujar authored
    Following prints are observed while testing audio on Jetson AGX Orin which
    has onboard RT5640 audio codec:
    
      BUG: sleeping function called from invalid context at kernel/workqueue.c:3027
      in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0
      preempt_count: 10001, expected: 0
      RCU nest depth: 0, expected: 0
      ------------[ cut here ]------------
      WARNING: CPU: 0 PID: 0 at kernel/irq/handle.c:159 __handle_irq_event_percpu+0x1e0/0x270
      ---[ end trace ad1c64905aac14a6 ]-
    
    The IRQ handler rt5640_irq() runs in interrupt context and can sleep
    during cancel_delayed_work_sync().
    
    Fix this by running IRQ handler, rt5640_irq(), in thread context.
    Hence replace request_irq() calls with devm_request_threaded_irq().
    
    Fixes: 051dade3 ("ASoC: rt5640: Fix the wrong state of JD1 and JD2")
    Cc: stable@vger.kernel.org
    Cc: Oder Chiou <oder_chiou@realtek.com>
    Signed-off-by: default avatarSameer Pujar <spujar@nvidia.com>
    Link: https://lore.kernel.org/r/1688015537-31682-4-git-send-email-spujar@nvidia.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    70a6404f
rt5640.c 94.4 KB