• Tao Liu's avatar
    x86/kexec: Add EFI config table identity mapping for kexec kernel · 5760929f
    Tao Liu authored
    A kexec kernel boot failure is sometimes observed on AMD CPUs due to an
    unmapped EFI config table array.  This can be seen when "nogbpages" is on
    the kernel command line, and has been observed as a full BIOS reboot rather
    than a successful kexec.
    
    This was also the cause of reported regressions attributed to Commit
    7143c5f4cf20 ("x86/mm/ident_map: Use gbpages only where full GB page should
    be mapped.") which was subsequently reverted.
    
    To avoid this page fault, explicitly include the EFI config table array in
    the kexec identity map.
    
    Further explanation:
    
    The following 2 commits caused the EFI config table array to be
    accessed when enabling sev at kernel startup.
    
        commit ec1c66af ("x86/compressed/64: Detect/setup SEV/SME features
                              earlier during boot")
        commit c01fce9c ("x86/compressed: Add SEV-SNP feature
                              detection/setup")
    
    This is in the code that examines whether SEV should be enabled or not, so
    it can even affect systems that are not SEV capable.
    
    This may result in a page fault if the EFI config table array's address is
    unmapped. Since the page fault occurs before the new kernel establishes its
    own identity map and page fault routines, it is unrecoverable and kexec
    fails.
    
    Most often, this problem is not seen because the EFI config table array
    gets included in the map by the luck of being placed at a memory address
    close enough to other memory areas that *are* included in the map created
    by kexec.
    
    Both the "nogbpages" command line option and the "use gpbages only where
    full GB page should be mapped" change greatly reduce the chance of being
    included in the map by luck, which is why the problem appears.
    Signed-off-by: default avatarTao Liu <ltao@redhat.com>
    Signed-off-by: default avatarSteve Wahl <steve.wahl@hpe.com>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Tested-by: default avatarPavin Joseph <me@pavinjoseph.com>
    Tested-by: default avatarSarah Brofeldt <srhb@dbc.dk>
    Tested-by: default avatarEric Hagberg <ehagberg@gmail.com>
    Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
    Link: https://lore.kernel.org/all/20240717213121.3064030-2-steve.wahl@hpe.com
    5760929f
machine_kexec_64.c 15.5 KB