• Andrey Vagin's avatar
    netlink: don't forget to release a rhashtable_iter structure · 733ade23
    Andrey Vagin authored
    This bug was detected by kmemleak:
    unreferenced object 0xffff8804269cc3c0 (size 64):
      comm "criu", pid 1042, jiffies 4294907360 (age 13.713s)
      hex dump (first 32 bytes):
        a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00  .2.,............
        00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de  ................
      backtrace:
        [<ffffffff8184dffa>] kmemleak_alloc+0x4a/0xa0
        [<ffffffff8124720f>] kmem_cache_alloc_trace+0x10f/0x280
        [<ffffffffa02864cc>] __netlink_diag_dump+0x26c/0x290 [netlink_diag]
    
    v2: don't remove a reference on a rhashtable_iter structure to
        release it from netlink_diag_dump_done
    
    Cc: Herbert Xu <herbert@gondor.apana.org.au>
    Fixes: ad202074 ("netlink: Use rhashtable walk interface in diag dump")
    Signed-off-by: default avatarAndrei Vagin <avagin@openvz.org>
    Acked-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    733ade23
diag.c 4.78 KB