• Lei Huang's avatar
    fuse: Fix missing FOLL_PIN for direct-io · 738adade
    Lei Huang authored
    Our user space filesystem relies on fuse to provide POSIX interface.
    In our test, a known string is written into a file and the content
    is read back later to verify correct data returned. We observed wrong
    data returned in read buffer in rare cases although correct data are
    stored in our filesystem.
    
    Fuse kernel module calls iov_iter_get_pages2() to get the physical
    pages of the user-space read buffer passed in read(). The pages are
    not pinned to avoid page migration. When page migration occurs, the
    consequence are two-folds.
    
    1) Applications do not receive correct data in read buffer.
    2) fuse kernel writes data into a wrong place.
    
    Using iov_iter_extract_pages() to pin pages fixes the issue in our
    test.
    
    An auxiliary variable "struct page **pt_pages" is used in the patch
    to prepare the 2nd parameter for iov_iter_extract_pages() since
    iov_iter_get_pages2() uses a different type for the 2nd parameter.
    
    [SzM] add iov_iter_extract_will_pin(ii) and unpin only if true.
    Signed-off-by: default avatarLei Huang <lei.huang@linux.intel.com>
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
    738adade
fuse_i.h 36.8 KB