• Guenter Roeck's avatar
    MIPS: Loongson: Use hwmon_device_register_with_groups() to register hwmon · abae018a
    Guenter Roeck authored
    Calling hwmon_device_register_with_info() with NULL dev and/or chip
    information parameters is an ABI abuse and not a real conversion to
    the new API. Also, the code creates sysfs attributes _after_ creating
    the hwmon device, which is racy and unsupported to start with. On top
    of that, the removal code tries to remove the name attribute which is
    owned by the hwmon core.
    
    Use hwmon_device_register_with_groups() to register the hwmon device
    instead.
    
    In the future, the hwmon subsystem will reject calls to
    hwmon_device_register_with_info with NULL dev or chip/info parameters.
    Without this patch, the hwmon device will fail to register.
    
    Fixes: f59dc511 ("MIPS: Loongson: Fix boot warning about hwmon_device_register()")
    Cc: Zhi Li <lizhi01@loongson.cn>
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
    abae018a
cpu_hwmon.c 4.33 KB