• Trond Myklebust's avatar
    NFS: Fix nfs_wb_page() to always exit with an error or a clean page · 73e3302f
    Trond Myklebust authored
    It is possible for nfs_wb_page() to sometimes exit with 0 return value, yet
    the page is left in a dirty state.
    For instance in the case where the server rebooted, and the COMMIT request
    failed, then all the previously "clean" pages which were cached by the
    server, but were not guaranteed to have been writted out to disk,
    have to be redirtied and resent to the server.
    The fix is to have nfs_wb_page_priority() check that the page is clean
    before it exits...
    
    This fixes a condition that triggers the BUG_ON(PagePrivate(page)) in
    nfs_create_request() when we're in the nfs_readpage() path.
    
    Also eliminate a redundant BUG_ON(!PageLocked(page)) while we're at it. It
    turns out that clear_page_dirty_for_io() has the exact same test.
    Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
    73e3302f
write.c 39.5 KB