• Andrew Morton's avatar
    [PATCH] tuner driver fixes · 7541c77e
    Andrew Morton authored
    From: Gerd Knorr <kraxel@bytesex.org>
    
    "options tuner type=2" is just there for historical reasons and should
    only be used/needed if the main driver doesn't allow to configure the
    tuner type.  I'm not sure whenever I can remove that altogether without
    breaking anything.  There are several users of the tuner module, some
    outside the standard kernel tree ...
    
    > >         if (type < TUNERS) {
    > > +               t->type = type;
    > >                 printk("tuner: type forced to %d (%s) [insmod]\n",
    > >                        t->type,tuners[t->type].name);
    > >                 set_type(client,type);
    
    That is wrong, it will break in other corner cases, it may cause the
    set_type() function not doing the initializations.
    
    The prink can also be dropped because set_type does that too.  The patch
    below removes that.  It also makes the kernel messages a bit more verbose
    and adds support for two new tuners.
    7541c77e
tuner.c 31.2 KB