• Arnd Bergmann's avatar
    ata: dwc: add DMADEVICES dependency · 7598469a
    Arnd Bergmann authored
    The dwc_460ex SATA driver has become available on non-powerpc architectures
    and may cause randconfig build errors when CONFIG_DMADEVICES is not set
    and SATA_DWC_OLD_DMA is enabled:
    
    warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES)
    ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined!
    ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined!
    
    This adds an explcit Kconfig dependency to CONFIG_SATA_DWC so we
    cannot run into broken configurations. While it would also be
    possible to build the driver with both CONFIG_DMADEVICES
    and SATA_DWC_OLD_DMA disabled, that case is not useful because
    there is no fallback to PIO mode when the DMA engine is not
    usable.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Fixes: 50b43375 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel")
    Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    7598469a
Kconfig 25.4 KB