• Marcus Huewe's avatar
    net: neigh: Fix netevent NETEVENT_DELAY_PROBE_TIME_UPDATE notification · 7627ae60
    Marcus Huewe authored
    When setting a neigh related sysctl parameter, we always send a
    NETEVENT_DELAY_PROBE_TIME_UPDATE netevent. For instance, when
    executing
    
    	sysctl net.ipv6.neigh.wlp3s0.retrans_time_ms=2000
    
    a NETEVENT_DELAY_PROBE_TIME_UPDATE netevent is generated.
    
    This is caused by commit 2a4501ae ("neigh: Send a
    notification when DELAY_PROBE_TIME changes"). According to the
    commit's description, it was intended to generate such an event
    when setting the "delay_first_probe_time" sysctl parameter.
    
    In order to fix this, only generate this event when actually
    setting the "delay_first_probe_time" sysctl parameter. This fix
    should not have any unintended side-effects, because all but one
    registered netevent callbacks check for other netevent event
    types (the registered callbacks were obtained by grepping for
    "register_netevent_notifier"). The only callback that uses the
    NETEVENT_DELAY_PROBE_TIME_UPDATE event is
    mlxsw_sp_router_netevent_event() (in
    drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c): in case
    of this event, it only accesses the DELAY_PROBE_TIME of the
    passed neigh_parms.
    
    Fixes: 2a4501ae ("neigh: Send a notification when DELAY_PROBE_TIME changes")
    Signed-off-by: default avatarMarcus Huewe <suse-tux@gmx.de>
    Reviewed-by: default avatarIdo Schimmel <idosch@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    7627ae60
neighbour.c 78.6 KB