• Roel Kluin's avatar
    net pcmcia: worklimit reaches -1 · b9bdcd9b
    Roel Kluin authored
    with while (--worklimit >= 0); worklimit reaches -1 after the loop. In
    3c589_cs.c this caused a warning not to be printed.
    
    In 3c574_cs.c contrastingly, el3_rx() treats worklimit differently:
    
    static int el3_rx(struct net_device *dev, int worklimit)
    {
    	while (--worklimit >= 0) { ... }
    	return worklimit;
    }
    
    el3_rx() is only called by function el3_interrupt(): twice:
    
    static irqreturn_t el3_interrupt(int irq, void *dev_id)
    {
            int work_budget = max_interrupt_work;
    	while(...) {
    		if (...)
    			work_budget = el3_rx(dev, work_budget);
    		if (...)
    			work_budget = el3_rx(dev, work_budget);
    		if (--work_budget < 0) {
    		        ...
    		        break;
    		}
    	}
    }
    The error path can occur 2 too early.
    Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    b9bdcd9b
3c574_cs.c 34.9 KB