• Neil Horman's avatar
    [PATCH] olympic driver: fix kernel oops on lobe fault · 8998ae21
    Neil Horman authored
    It fixes an oops that results when a lobe fault is detected.  The oops
    occurs because a lobe fault triggers an interrupt which is handled
    in the current version of the driver by effectively shutting down the
    card, and freeing its requisite irq.  The former is fine, the latter
    is not, as its illegal to free an irq from within an interrupt context.
    
    I've fixed this bug by removing the call to free_irq from the interrupt
    handler (specifically the chunk around line 964 fixes that).  While I
    was in there I noticed that there were several other conditions in
    the interrupt handler that contained the same condition, so I made
    the same fix there.  I re-added.
    
    I also modified the contents of olympic_freemem (the chunk around line
    898 to correct a misuse of a pointer after it requisite memory has
    been free in the case the the adapter is re-initalized after a fault
    to prevent that oops.  And then I clean up the interrupt handler to
    simply use olympic_freemem from the close routine since the ring buffer
    doesn't need to be freed until the driver is closed.
    
    In addition to these changes I added a call to olympic init in
    olympic_open and reset the spinlock so the adapter can be reset and
    rejoin the ring without needing to rmmod/insmod the module.  Lastly I
    cleaned up the wait queue code so that the close routine didn't have
    to wait 60 seconds to close the adapter if a fatal fault has closed
    the adapter.
    Signed-off-by: default avatarNeil Horman <nhorman@redhat.com>
    8998ae21
olympic.c 65.6 KB