• Srinivas Kandagatla's avatar
    tty: msm_serial: remove static clk rate setting in probe · 79c9473f
    Srinivas Kandagatla authored
    The issue with setting up a fixed clock rate at probe is that it would
    overwrite the console rate set by the bootloader for its console device.
    This would result in serial out corruption or missing log when we system
    is booted with earlycon. This is not a issue if we boot system without
    earlycon.
    
    This setup is at least not required with the mainline driver, this code
    used to be required because the clk_enable() call would fail if
    clk_set_rate() wasn't called first.
    
    Originally the issue was noticed on DB410c which is based on APQ8016
    chipset.
    
    Without this patch the console log with earlycon would look like:
    ...
    [    0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=1
    [    0.000000] NR_IRQS:64 nr_irqs:64 0
    ����+HH��0.699378] console [ttyMSM0] enabled
    [    0.699378] console [ttyMSM0] enabled
    [    0.702003] bootconsole [uart0] disabled
    [    0.702003] bootconsole [uart0] disabled
    ...
    
    with this patch I can see all the skipped lines on the console
    Reviewed-by: default avatarStephen Boyd <sboyd@codeaurora.org>
    Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Acked-by: default avatarAndy Gross <andy.gross@linaro.org>
    Tested-by: default avatarPramod Gurav <gpramod@codeaurora.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    79c9473f
msm_serial.c 38 KB