• Jason Gunthorpe's avatar
    drm: Remove SCATTERLIST_MAX_SEGMENT · 7a60c2dd
    Jason Gunthorpe authored
    Since commit 9a40401c ("lib/scatterlist: Do not limit max_segment to
    PAGE_ALIGNED values") the max_segment input to sg_alloc_table_from_pages()
    does not have to be any special value. The new algorithm will always
    create something less than what the user provides. Thus eliminate this
    confusing constant.
    
    - vmwgfx should use the HW capability, not mix in the OS page size for
      calling dma_set_max_seg_size()
    
    - i915 uses i915_sg_segment_size() both for sg_alloc_table_from_pages
      and for some open coded sgl construction. This doesn't change the value
      since rounddown(size, UINT_MAX) == SCATTERLIST_MAX_SEGMENT
    
    - drm_prime_pages_to_sg uses it as a default if max_segment is zero,
      UINT_MAX is fine to use directly.
    
    Cc: Gerd Hoffmann <kraxel@redhat.com>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Cc: Thomas Hellstrom <thellstrom@vmware.com>
    Cc: Qian Cai <cai@lca.pw>
    Cc: "Ursulin, Tvrtko" <tvrtko.ursulin@intel.com>
    Suggested-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    Link: https://patchwork.freedesktop.org/patch/msgid/0-v1-44733fccd781+13d-rm_scatterlist_max_jgg@nvidia.com
    7a60c2dd
i915_scatterlist.h 3.1 KB