• Hans de Goede's avatar
    platform/x86: ideapad-laptop: Make touchpad_ctrl_via_ec a module option · 301e0d76
    Hans de Goede authored
    Remove the ACPI-HID + DMI-id deny-lists for touchpad_ctrl_via_ec and
    instead make it a module option which defaults to false.
    
    The touchpad sysfs attribute allowing directly writing VPCCMD_W_TOUCHPAD
    from userspace has been leading to a lot of bug-reports / patches adding
    both ACPI HID + dmi-id based deny-lists for it which then need to be
    expanded all the time going forward leading to a high maintenance load.
    
    At the same time the touchpad sysfs attribute is not a standard Linux
    userspace API. So it is not used in standard desktop-enviroments, instead
    it is only used in the following 2 rare circumstances:
    
    1. Ideapad specific control-panel like applets
    2. Custom scripts written by users
    
    For 1. these applets need to already deal with the touchpad sysfs attr
    sometimes not being there because of the existing deny lists so hiding
    it be default should not cause an issue; and most desktop environments
    already have a touchpad-disable option in their native control-panel,
    so having an ideapad specific toggle for this is not necessary.
    
    For 2. since these users are already customizing their systems they
    can add the module option if they want to keep using the touchpad
    sysfs attribute.
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Reviewed-by: default avatarJiaxun Yang <jiaxun.yang@flygoat.com>
    Tested-by: default avatarJiaxun Yang <jiaxun.yang@flygoat.com>
    Tested-by: default avatarMaxim Mikityanskiy <maxtram95@gmail.com>
    Link: https://lore.kernel.org/r/20221117110244.67811-7-hdegoede@redhat.com
    301e0d76
ideapad-laptop.c 48.5 KB