• Damien Le Moal's avatar
    scsi: sd_zbc: Fix compilation warning · 7b10d7e3
    Damien Le Moal authored
    commit 0cdc5858 upstream.
    
    kbuild test robot gets the following compilation warning using gcc 7.4
    cross compilation for c6x (GCC_VERSION=7.4.0 make.cross ARCH=c6x).
    
       In file included from include/asm-generic/bug.h:18:0,
                        from arch/c6x/include/asm/bug.h:12,
                        from include/linux/bug.h:5,
                        from include/linux/thread_info.h:12,
                        from include/asm-generic/current.h:5,
                        from ./arch/c6x/include/generated/asm/current.h:1,
                        from include/linux/sched.h:12,
                        from include/linux/blkdev.h:5,
                        from drivers//scsi/sd_zbc.c:11:
       drivers//scsi/sd_zbc.c: In function 'sd_zbc_read_zones':
    >> include/linux/kernel.h:62:48: warning: 'zone_blocks' may be used
       uninitialized in this function [-Wmaybe-uninitialized]
        #define __round_mask(x, y) ((__typeof__(x))((y)-1))
                                                       ^
       drivers//scsi/sd_zbc.c:464:6: note: 'zone_blocks' was declared here
         u32 zone_blocks;
             ^~~~~~~~~~~
    
    This is a false-positive report. The variable zone_blocks is always
    initialized in sd_zbc_check_zones() before use. It is not initialized
    only and only if sd_zbc_check_zones() fails.
    
    Avoid this warning by initializing the zone_blocks variable to 0.
    
    Fixes: 5f832a39 ("scsi: sd_zbc: Fix sd_zbc_check_zones() error checks")
    Cc: Stable <stable@vger.kernel.org>
    Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    7b10d7e3
sd_zbc.c 13.1 KB