• Benjamin Herrenschmidt's avatar
    ALSA: vmalloc buffers should use normal mmap · 3674f19d
    Benjamin Herrenschmidt authored
    It's a big no-no to use pgprot_noncached() when mmap'ing such buffers
    into userspace since they are mapped cachable in kernel space.
    
    This can cause all sort of interesting things ranging from to garbled
    sound to lockups on various architectures. I've observed that usb-audio
    is broken on powerpc 4xx for example because of that.
    
    Also remove the now unused snd_pcm_lib_mmap_noncached(). It's
    an arch business to know when to use uncached mappings, there's
    already hacks for MIPS inside snd_pcm_default_mmap() and other
    archs are supposed to use dma_mmap_coherent().
    
    (See my separate patch that adds dma_mmap_coherent() to powerpc)
    Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    CC: <stable@kernel.org>
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    3674f19d
pcm_native.c 93.6 KB