• Arthur Gautier's avatar
    netlink: fixup regression in RTM_GETADDR · 7c1e8a38
    Arthur Gautier authored
    This commit fixes a regression in AF_INET/RTM_GETADDR and
    AF_INET6/RTM_GETADDR.
    
    Before this commit, the kernel would stop dumping addresses once the first
    skb was full and end the stream with NLMSG_DONE(-EMSGSIZE). The error
    shouldn't be sent back to netlink_dump so the callback is kept alive. The
    userspace is expected to call back with a new empty skb.
    
    Changes from V1:
     - The error is not handled in netlink_dump anymore but rather in
       inet_dump_ifaddr and inet6_dump_addr directly as suggested by
       David Ahern.
    
    Fixes: d7e38611 ("net/ipv4: Put target net when address dump fails due to bad attributes")
    Fixes: 242afaa6 ("net/ipv6: Put target net when address dump fails due to bad attributes")
    
    Cc: David Ahern <dsahern@gmail.com>
    Cc: "David S . Miller" <davem@davemloft.net>
    Cc: netdev@vger.kernel.org
    Signed-off-by: default avatarArthur Gautier <baloo@gandi.net>
    Reviewed-by: default avatarDavid Ahern <dsahern@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    7c1e8a38
devinet.c 66 KB