• Linus Lüssing's avatar
    batman-adv: Fix symmetry check / route flapping in multi interface setups · 7caf69fb
    Linus Lüssing authored
    If receiving an OGM from a neighbor other than the currently selected
    and if it has the same TQ then we are supposed to switch if this
    neighbor provides a more symmetric link than the currently selected one.
    
    However this symmetry check currently is broken if the interface of the
    neighbor we received the OGM from and the one of the currently selected
    neighbor differ: We are currently trying to determine the symmetry of the
    link towards the selected router via the link we received the OGM from
    instead of just checking via the link towards the currently selected
    router.
    
    This leads to way more route switches than necessary and can lead to
    permanent route flapping in many common multi interface setups.
    
    This patch fixes this issue by using the right interface for this
    symmetry check.
    Signed-off-by: default avatarLinus Lüssing <linus.luessing@web.de>
    7caf69fb
bat_iv_ogm.c 40.3 KB