• Lyude Paul's avatar
    drm/amdgpu/mst: Stop ignoring error codes and deadlocking · 7cce4cd6
    Lyude Paul authored
    It appears that amdgpu makes the mistake of completely ignoring the return
    values from the DP MST helpers, and instead just returns a simple
    true/false. In this case, it seems to have come back to bite us because as
    a result of simply returning false from
    compute_mst_dsc_configs_for_state(), amdgpu had no way of telling when a
    deadlock happened from these helpers. This could definitely result in some
    kernel splats.
    
    V2:
    * Address Wayne's comments (fix another bunch of spots where we weren't
      passing down return codes)
    Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
    Fixes: 8c20a1ed ("drm/amd/display: MST DSC compute fair share")
    Cc: Harry Wentland <harry.wentland@amd.com>
    Cc: <stable@vger.kernel.org> # v5.6+
    Reviewed-by: default avatarWayne Lin <Wayne.Lin@amd.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    7cce4cd6
amdgpu_dm.c 295 KB