• Stephan Mueller's avatar
    crypto: af_alg - remove locking in async callback · 7d2c3f54
    Stephan Mueller authored
    The code paths protected by the socket-lock do not use or modify the
    socket in a non-atomic fashion. The actions pertaining the socket do not
    even need to be handled as an atomic operation. Thus, the socket-lock
    can be safely ignored.
    
    This fixes a bug regarding scheduling in atomic as the callback function
    may be invoked in interrupt context.
    
    In addition, the sock_hold is moved before the AIO encrypt/decrypt
    operation to ensure that the socket is always present. This avoids a
    tiny race window where the socket is unprotected and yet used by the AIO
    operation.
    
    Finally, the release of resources for a crypto operation is moved into a
    common function of af_alg_free_resources.
    
    Cc: <stable@vger.kernel.org>
    Fixes: e870456d ("crypto: algif_skcipher - overhaul memory management")
    Fixes: d887c52d ("crypto: algif_aead - overhaul memory management")
    Reported-by: default avatarRomain Izard <romain.izard.pro@gmail.com>
    Signed-off-by: default avatarStephan Mueller <smueller@chronox.de>
    Tested-by: default avatarRomain Izard <romain.izard.pro@gmail.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    7d2c3f54
if_alg.h 6.96 KB