• Pablo Neira Ayuso's avatar
    netfilter: nft_set_rbtree: bogus lookup/get on consecutive elements in named sets · db3b665d
    Pablo Neira Ayuso authored
    The existing rbtree implementation might store consecutive elements
    where the closing element and the opening element might overlap, eg.
    
    	[ a, a+1) [ a+1, a+2)
    
    This patch removes the optimization for non-anonymous sets in the exact
    matching case, where it is assumed to stop searching in case that the
    closing element is found. Instead, invalidate candidate interval and
    keep looking further in the tree.
    
    The lookup/get operation might return false, while there is an element
    in the rbtree. Moreover, the get operation returns true as if a+2 would
    be in the tree. This happens with named sets after several set updates.
    
    The existing lookup optimization (that only works for the anonymous
    sets) might not reach the opening [ a+1,... element if the closing
    ...,a+1) is found in first place when walking over the rbtree. Hence,
    walking the full tree in that case is needed.
    
    This patch fixes the lookup and get operations.
    
    Fixes: e701001e ("netfilter: nft_rbtree: allow adjacent intervals with dynamic updates")
    Fixes: ba0e4d99 ("netfilter: nf_tables: get set elements via netlink")
    Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
    db3b665d
nft_set_rbtree.c 12.9 KB