• Ilpo Järvinen's avatar
    selftests/resctrl: Fix MBM test failure when MBA unavailable · 5247e6db
    Ilpo Järvinen authored
    Commit 20d96b25 ("selftests/resctrl: Fix schemata write error
    check") exposed a problem in feature detection logic in MBM selftest.
    If schemata does not support MB:x=x entries, the schemata write to
    initialize 100% memory bandwidth allocation in mbm_setup() will now
    fail with -EINVAL due to the error handling corrected by the commit
    20d96b25 ("selftests/resctrl: Fix schemata write error check").
    That commit just uncovers the failed write, it is not wrong itself.
    
    If MB:x=x is not supported by schemata, it is safe to assume 100%
    memory bandwidth is always set. Therefore, the previously ignored error
    does not make the MBM test itself wrong.
    
    Restore the previous behavior of MBM test by checking MB support before
    attempting to write it into schemata which results in behavior
    equivalent to ignoring the write error.
    
    Fixes: 20d96b25 ("selftests/resctrl: Fix schemata write error check")
    Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
    Reviewed-by: default avatarReinette Chatre <reinette.chatre@intel.com>
    Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
    5247e6db
mbm_test.c 2.89 KB