• David Sterba's avatar
    btrfs: drop NOFAIL from set_extent_bit allocation masks · 7dde7a8a
    David Sterba authored
    The __GFP_NOFAIL passed to set_extent_bit first appeared in 2010
    (commit f0486c68 ("Btrfs: Introduce contexts for metadata
    reservation")), without any explanation why it would be needed.
    
    Meanwhile we've updated the semantics of set_extent_bit to handle failed
    allocations and do unlock, sleep and retry if needed.  The use of the
    NOFAIL flag is also an outlier, we never want any of the set/clear
    extent bit helpers to fail, they're used for many critical changes like
    extent locking, besides the extent state bit changes.
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    7dde7a8a
extent-tree.c 166 KB