• Tom Rix's avatar
    mctp: fix use after free · 7e5b6a5c
    Tom Rix authored
    Clang static analysis reports this problem
    route.c:425:4: warning: Use of memory after it is freed
      trace_mctp_key_acquire(key);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    When mctp_key_add() fails, key is freed but then is later
    used in trace_mctp_key_acquire().  Add an else statement
    to use the key only when mctp_key_add() is successful.
    
    Fixes: 4f9e1ba6 ("mctp: Add tracepoints for tag/key handling")
    Signed-off-by: default avatarTom Rix <trix@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    7e5b6a5c
route.c 29.2 KB