• Niklas Cassel's avatar
    firmware: qcom: scm: Fix crash in qcom_scm_call_atomic1() · 5ec3444c
    Niklas Cassel authored
    qcom_scm_call_atomic1() can crash with a NULL pointer dereference at
    qcom_scm_call_atomic1+0x30/0x48.
    
    disassembly of qcom_scm_call_atomic1():
    ...
    <0xc08d73b0 <+12>: ldr r3, [r12]
    ... (no instruction explicitly modifies r12)
    0xc08d73cc <+40>: smc 0
    ... (no instruction explicitly modifies r12)
    0xc08d73d4 <+48>: ldr r3, [r12] <- crashing instruction
    ...
    
    Since the first ldr is successful, and since r12 isn't explicitly
    modified by any instruction between the first and the second ldr,
    it must have been modified by the smc call, which is ok,
    since r12 is caller save according to the AAPCS.
    
    Add r12 to the clobber list so that the compiler knows that the
    callee potentially overwrites the value in r12.
    Clobber descriptions may not in any way overlap with an input or
    output operand.
    Signed-off-by: default avatarNiklas Cassel <niklas.cassel@linaro.org>
    Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    Reviewed-by: default avatarStephen Boyd <sboyd@kernel.org>
    Signed-off-by: default avatarAndy Gross <andy.gross@linaro.org>
    5ec3444c
qcom_scm-32.c 15.6 KB