• Vivek Goyal's avatar
    virtiofs: do not use fuse_fill_super_common() for device installation · 7fd3abfa
    Vivek Goyal authored
    fuse_fill_super_common() allocates and installs one fuse_device.  Hence
    virtiofs allocates and install all fuse devices by itself except one.
    
    This makes logic little twisted.  There does not seem to be any real need
    that why virtiofs can't allocate and install all fuse devices itself.
    
    So opt out of fuse device allocation and installation while calling
    fuse_fill_super_common().
    
    Regular fuse still wants fuse_fill_super_common() to install fuse_device.
    It needs to prevent against races where two mounters are trying to mount
    fuse using same fd.  In that case one will succeed while other will get
    -EINVAL.
    
    virtiofs does not have this issue because sget_fc() resolves the race
    w.r.t multiple mounters and only one instance of virtio_fs_fill_super()
    should be in progress for same filesystem.
    Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
    7fd3abfa
inode.c 35.3 KB