• Arnd Bergmann's avatar
    asm-generic: simplify asm/unaligned.h · 803f4e1e
    Arnd Bergmann authored
    The get_unaligned()/put_unaligned() implementations are much more complex
    than necessary, now that all architectures use the same code.
    
    Move everything into one file and use a much more compact way to express
    the same logic.
    
    I've compared the binary output using gcc-11 across defconfig builds for
    all architectures and found this patch to make no difference, except for
    a single function on powerpc that needs two additional register moves
    because of random differences in register allocation.
    
    There are a handful of callers of the low-level __get_unaligned_cpu32,
    so leave that in place for the time being even though the common code
    no longer uses it.
    
    This adds a warning for any caller of get_unaligned()/put_unaligned()
    that passes in a single-byte pointer, but I've sent patches for all
    instances that show up in x86 and randconfig builds. It would be nice
    to change the arguments of the endian-specific accessors to take the
    matching __be16/__be32/__be64/__le16/__le32/__le64 arguments instead of
    a void pointer, but that requires more changes to the rest of the kernel.
    
    This new version does allow aggregate types into get_unaligned(), which
    was not the original goal but might come in handy.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    803f4e1e
unaligned.h 2.82 KB