• Greg Kroah-Hartman's avatar
    Revert "kernfs: fix memleak in kernel_ops_readdir()" · 8097c43b
    Greg Kroah-Hartman authored
    This reverts commit cc798c83.
    
    Tony writes:
    	Somehow this causes a regression in Linux next for me where I'm
    	seeing lots of sysfs entries now missing under
    	/sys/bus/platform/devices.
    
    	For example, I now only see one .serial entry show up in sysfs.
    	Things work again if I revert commit cc798c83 ("kernfs: fix
    	memleak inkernel_ops_readdir()"). Any ideas why that would be?
    
    Tejun says:
    	Ugh, you're right.  It can get double-put cuz ctx->pos is put by
    	release too.
    
    So reverting it for now.
    Reported-by: default avatarTony Lindgren <tony@atomide.com>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: Tejun Heo <tj@kernel.org>
    Fixes: cc798c83 ("kernfs: fix memleak in kernel_ops_readdir()")
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    8097c43b
dir.c 42.5 KB